AlenkaF commented on PR #36701: URL: https://github.com/apache/arrow/pull/36701#issuecomment-1687478804
Thank you for the contribution @Kimahriman ! The PR looks good! As you have mentioned, there might be some improvement possible with consolidating the common code. In the C++ part, where I am a novice also - but, I would try with creating a heper Status function and see if I can make it work with both builder instances or not (am not really sure it will work). As for the python test, it could also be consolidated with `test_numpy_binary_overflow_to_chunked` with parametrizing the test function as for example in https://github.com/apache/arrow/blob/9ecd0f2a5fb76cca859269a6ff13eaf315abac62/python/pyarrow/tests/test_array.py#L635. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
