jorisvandenbossche commented on code in PR #36701:
URL: https://github.com/apache/arrow/pull/36701#discussion_r1301320197
##########
python/pyarrow/src/arrow/python/numpy_to_arrow.cc:
##########
@@ -656,6 +693,33 @@ Status AppendUTF32(const char* data, int itemsize, int
byteorder,
reinterpret_cast<const uint8_t*>(PyBytes_AS_STRING(utf8_obj.obj())),
length);
}
+Status AppendUTF32(const char* data, int itemsize, int byteorder,
+ ::arrow::LargeStringBuilder* builder) {
Review Comment:
For this function, only the final line of the function actually uses
`builder`. So I think it should be possible to factor out most part of this
function into something that can be reused, and only have the actual
`builder->Append(..)` in a type-specific AppendUTF32?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
