tustvold commented on code in PR #7375:
URL: https://github.com/apache/arrow-datafusion/pull/7375#discussion_r1301881216
##########
datafusion/common/src/scalar.rs:
##########
@@ -2072,53 +1188,48 @@ impl ScalarValue {
}
}
+ /// Wrapping addition of `ScalarValue`
+ ///
+ /// NB: operating on `ScalarValue` directly is not efficient, performance
sensitive code
+ /// should instead make use of vectorized array kernels
pub fn add<T: Borrow<ScalarValue>>(&self, other: T) -> Result<ScalarValue>
{
Review Comment:
The performance of this is likely worse, however, following #7358 the only
use of this logic is within the range analysis framework, the median
accumulator (to average two values in the event of an even number), and Range
window functions, none of which I would consider performance critical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
