sgilmore10 opened a new pull request, #37315:
URL: https://github.com/apache/arrow/pull/37315

   <!--
   Thanks for opening a pull request!
   If this is your first pull request you can find detailed information on how 
   to contribute here:
     * [New Contributor's 
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing 
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   
   If this is not a [minor 
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). 
Could you open an issue for this pull request on GitHub? 
https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the 
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
 of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   Now that `arrow.type.Time32Type` class has been added to the MATLAB 
Interface (#37250), we can add the `arrow.array.Time32Array` class. 
   
   ### What changes are included in this PR?
   
   1. Added a new class `arrow.array.Time32Array`. It has the following 
read-only properties: `Type` and `Length`. It has the following methods: 
`fromMATLAB()`, `toMATLAB()`, and `duration()`.
   2. Added a new class called `arrow.type.traits.Time32Traits`.
   
   **Example Usage**
   
   ```matlab
   >> times = seconds([100 120 NaN 200])
   
   times = 
   
     1×4 duration array
   
      100 sec   120 sec   NaN sec   200 sec
   
   >> time32Array = arrow.array.Time32Array.fromMATLAB(times)
   
   time32Array = 
   
   [
     00:01:40,
     00:02:00,
     null,
     00:03:20
   ]
   
   >> roundtrip = toMATLAB(time32Array)
   
   roundtrip = 
   
     4×1 duration array
   
      100 sec
      120 sec
      NaN sec
      200 sec
   
   ```
   
   You can also specify the `TimeUnit` to use via a name-value pair. `TimeUnit` 
can either be `"Second"`  (default) or `"Milisecond"`.
   
   ```matlab
   >> times = seconds([100 120 NaN 200]);
   >> time32Array = arrow.array.Time32Array.fromMATLAB(times, 
TimeUnit="Millisecond")
   
   time32Array = 
   
   [
     00:01:40.000,
     00:02:00.000,
     null,
     00:03:20.000
   ]
   ```
   
   ### Are these changes tested?
   
   Yes. Added two new test classes: `tTime32Array.m` and `tTime32Traits.m`.
   
   ### Are there any user-facing changes?
   
   Yes, users can now create `arrow.array.Time32Array`s from MATLAB `duration`s 
via the static `fromMATLAB` method on `arrow.array.Time32Array`.
   
   ### Future Directions
   
   1. Add `arrow.array.Time64Array`
   2. Add `arrow.type.Date32Type` and `arrow.array.Date32Array`
   3. Add `arrow.type.Date64Type` and `arrow.array.Date64Array`
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please uncomment the line 
below and explain which changes are breaking.
   -->
   <!-- **This PR includes breaking changes to public APIs.** -->
   
   <!--
   Please uncomment the line below (and provide explanation) if the changes fix 
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid 
data to be produced, or (c) a bug that causes a crash (even when the API 
contract is upheld). We use this to highlight fixes to issues that may affect 
users without their knowledge. For this reason, fixing bugs that cause errors 
don't count, since those are usually obvious.
   -->
   <!-- **This PR contains a "Critical Fix".** -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to