2010YOUY01 commented on PR #7337: URL: https://github.com/apache/arrow-datafusion/pull/7337#issuecomment-1689064579
> Thank you @2010YOUY01 . This PR, as all your others, is well written, documented and tested and is easy to read and understand. Thank you so much. > > # Sorting > I started looking at this implementation and I agree with you that trying to store all the values for the group is unlikely to work well once the data gets to a certain size Thank you for this very detailed review feedback! This `order by` approach is what I was thinking about, will try to do this approach. I'm trying to figure out how to do this query rewrite, do you remember any reference PR that did a query rewrite similar to this `order by` rewrite? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
