wgtmac commented on code in PR #36574:
URL: https://github.com/apache/arrow/pull/36574#discussion_r1302534492
##########
cpp/src/parquet/page_index.h:
##########
@@ -186,8 +191,7 @@ class PARQUET_EXPORT PageIndexReader {
/// that creates this PageIndexReader.
static std::shared_ptr<PageIndexReader> Make(
::arrow::io::RandomAccessFile* input, std::shared_ptr<FileMetaData>
file_metadata,
- const ReaderProperties& properties,
- std::shared_ptr<InternalFileDecryptor> file_decryptor = NULLPTR);
+ const ReaderProperties& properties, InternalFileDecryptor*
file_decryptor);
Review Comment:
For `RandomAccessFile*` and `InternalFileDecryptor*`, I want to explicitly
state that returned PageIndexReader does not own these objects and they are
owned by the parquet file reader. However, it is unfortunate that no one owns
`file_metadata` so it must be a `std::shared_ptr<FileMetaData>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
