pitrou commented on code in PR #36967:
URL: https://github.com/apache/arrow/pull/36967#discussion_r1302995258
##########
cpp/src/arrow/dataset/scanner.h:
##########
@@ -136,6 +137,9 @@ struct ARROW_DS_EXPORT ScanOptions {
/// Parameters which control when the plan should pause for a slow consumer
acero::BackpressureOptions backpressure =
acero::BackpressureOptions::DefaultBackpressure();
+
+ int64_t start_offset = kDefaultStartOffset;
+ int64_t length;
Review Comment:
1. Can you please add docstrings?
2. In which unit is this expressed? Number of rows? Something else?
3. Why doesn't `length` have a default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
