pitrou commented on code in PR #37174:
URL: https://github.com/apache/arrow/pull/37174#discussion_r1303023093
##########
go/arrow/cdata/cdata_test_framework.go:
##########
@@ -277,6 +282,12 @@ func createCArr(arr arrow.Array) *CArrowArray {
carr.length = C.int64_t(arr.Len())
carr.null_count = C.int64_t(arr.NullN())
carr.offset = C.int64_t(arr.Data().Offset())
+ carr.release = (*[0]byte)(C.release_test_arr)
+
+ if arr.DataType().ID() == arrow.RUN_END_ENCODED {
Review Comment:
Instead of testing the type id, why not test the number of buffers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
