lidavidm commented on code in PR #35570:
URL: https://github.com/apache/arrow/pull/35570#discussion_r1303368552
##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java:
##########
@@ -25,8 +26,9 @@
* Options used during scanning.
*/
public class ScanOptions {
- private final Optional<String[]> columns;
+ private final Optional<String[]> columnsSubset;
private final long batchSize;
+ private Optional<ByteBuffer> columnsProduceOrFilter;
Review Comment:
The string parsing can and should be kept separate. The actual interface
should reflect Substrait. (We could add a convenience method to set the filter
via a string, which gets immediately parsed, for instance.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
