sgilmore10 opened a new pull request, #37347:
URL: https://github.com/apache/arrow/pull/37347
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
The `column(index)` method of `arrow.tabular.RecordBatch` errors if `index`
refers to an `arrow.array.Time32Array` column.
```matlab
>> string = arrow.array(["A", "B", "C"]);
>> time32 = arrow.array.Time32Array.fromMATLAB(seconds(1:3));
>> rb = arrow.tabular.RecordBatch.fromArrays(string, time32,
ColumnNames=["String", "Time32"])
rb =
String: [
"A",
"B",
"C"
]
Time32: [
00:00:01,
00:00:02,
00:00:03
]
>> time32Column = rb.column(2)
Error using .
Unsupported DataType: time32[s]
Error in arrow.tabular.RecordBatch/column (line 63)
[proxyID, typeID] = obj.Proxy.getColumnByIndex(args);
```
`column(index)` is throwing this error because the case for `Time32` was not
added to `arrow::matlab::array::proxy::wrap(arrowArray)` in #37315.
`column(index)` calls this function to create proxy objects around existing
arrow arrays.existing arrow arrays. Adding the case for `Time32` will resolve
this bug.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
1. Updated `arrow::Result<proxy::Array> wrap(const
std::shared_ptr<arrow::Array>& array)` to handle wrap `arrow::Time32Array`
instances within `proxy::TIme32Array`s.
2. Added a new test utility called
`arrow.internal.test.tabular.createAllSupportedArrayTypes`, which returns two
cell arrays: `arrowArrays` and `matlabData`. The `arrowArrays` cell array
contains one instance of each concrete subclass of `arrow.array.Array`. The
`matlabData` cell array contains the MATLAB arrays used to generate each array
in `arrowArrays`. This utility can be used to create an
`arrow.array.RecordBatch` that contains all the arrow array types that are
supported by the MATLAB interface.
### Are these changes tested?
Yes. Updated the `fromArrays` test cases in `tRecordBatch` to verify the
`column(index)` method of `arrow.type.RecordBatch` supports extracting columns
of any arrow type (supported by the MATLAB Interface).
### Are there any user-facing changes?
Yes. Fixed a bug in `arrow.tabular.RecordBatch`.
### Future Directions
1. #37345
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line
below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
