kou commented on code in PR #37311:
URL: https://github.com/apache/arrow/pull/37311#discussion_r1303654154


##########
cpp/examples/tutorial_examples/CMakeLists.txt:
##########
@@ -22,8 +22,7 @@ project(ArrowTutorialExamples)
 find_package(Arrow REQUIRED)
 
 get_filename_component(ARROW_CONFIG_PATH ${Arrow_CONFIG} DIRECTORY)

Review Comment:
   ```suggestion
   ```



##########
cpp/examples/tutorial_examples/run.sh:
##########
@@ -45,6 +45,8 @@ echo "== Running example project"
 echo "=="
 echo
 
+export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/lib

Review Comment:
   Oh, sorry. How about specifying rpath to Arrow C++ too?
   
   ```diff
   diff --git a/cpp/examples/tutorial_examples/run.sh 
b/cpp/examples/tutorial_examples/run.sh
   index 4e5e8eeab..bc0078435 100755
   --- a/cpp/examples/tutorial_examples/run.sh
   +++ b/cpp/examples/tutorial_examples/run.sh
   @@ -30,7 +30,8 @@ echo "== Building Arrow C++ library"
    echo "=="
    echo
    
   -ARROW_CMAKE_OPTIONS="-DCMAKE_INSTALL_PREFIX=${ARROW_INSTALL_DIR}" \
   +ARROW_CMAKE_OPTIONS="-DCMAKE_INSTALL_PREFIX=${ARROW_INSTALL_DIR} \
   +                     -DCMAKE_INSTALL_RPATH=${ARROW_INSTALL_DIR}/lib" \
      ./build_arrow.sh
    
    echo
   @@ -39,7 +40,8 @@ echo "== Building example project using Arrow C++ library"
    echo "=="
    echo
    
   -EXAMPLE_CMAKE_OPTIONS="-DCMAKE_INSTALL_RPATH=${ARROW_INSTALL_DIR}/lib 
-DCMAKE_PREFIX_PATH=${ARROW_INSTALL_DIR}" \
   +EXAMPLE_CMAKE_OPTIONS="-DCMAKE_INSTALL_RPATH=${ARROW_INSTALL_DIR}/lib \
   +                       -DCMAKE_PREFIX_PATH=${ARROW_INSTALL_DIR}" \
      ./build_example.sh
    
    echo
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to