kou commented on code in PR #36835: URL: https://github.com/apache/arrow/pull/36835#discussion_r1303733940
########## cpp/thirdparty/versions.txt: ########## @@ -53,6 +53,9 @@ ARROW_AWS_LC_BUILD_VERSION=v1.3.0 ARROW_AWS_LC_BUILD_SHA256_CHECKSUM=ae96a3567161552744fc0cae8b4d68ed88b1ec0f3d3c98700070115356da5a37 ARROW_AWSSDK_BUILD_VERSION=1.10.55 ARROW_AWSSDK_BUILD_SHA256_CHECKSUM=2d552fb1a84bef4a9b65e34aa7031851ed2aef5319e02cc6e4cb735c48aa30de +# Despite the confusing version name this is still the whole azure SDK including core, keyvault, storage-common, etc. Review Comment: ```suggestion # Despite the confusing version name this is still the whole Azure SDK for C++ including core, keyvault, storage-common, etc. ``` ########## cpp/cmake_modules/FindAzure.cmake: ########## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +if(Azure_FOUND) + return() +endif() + +set(find_package_args) +list(APPEND find_package_args + CONFIG +) Review Comment: Fix style. ```suggestion list(APPEND find_package_args CONFIG) ``` ########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -5039,6 +5057,49 @@ if(ARROW_S3) endif() endif() +# ---------------------------------------------------------------------- +# Azure SDK for C++ + +function(build_azure_sdk) + message(STATUS "Building Azure SDK for C++ from source") + fetchcontent_declare(azure_sdk + URL ${ARROW_AZURE_SDK_URL} + URL_HASH "SHA256=${ARROW_AZURE_SDK_BUILD_SHA256_CHECKSUM}") + fetchcontent_getproperties(azure_sdk) + if(NOT azure_sdk_POPULATED) + fetchcontent_populate(azure_sdk) + set(BUILD_PERFORMANCE_TESTS FALSE) + set(BUILD_SAMPLES FALSE) + set(BUILD_TESTING FALSE) + set(BUILD_WINDOWS_UWP TRUE) + set(CMAKE_EXPORT_NO_PACKAGE_REGISTRY TRUE) + set(DISABLE_AZURE_CORE_OPENTELEMETRY TRUE) + add_subdirectory(${azure_sdk_SOURCE_DIR} ${azure_sdk_BINARY_DIR} EXCLUDE_FROM_ALL) + endif() + set(AZURE_SDK_VENDORED + TRUE + PARENT_SCOPE) + list(APPEND + ARROW_BUNDLED_STATIC_LIBS + Azure::azure-core + Azure::azure-identity + Azure::azure-storage-blobs + Azure::azure-storage-common + Azure::azure-storage-files-datalake) +set(ARROW_BUNDLED_STATIC_LIBS + ${ARROW_BUNDLED_STATIC_LIBS} + PARENT_SCOPE) Review Comment: Fix style. ```suggestion set(ARROW_BUNDLED_STATIC_LIBS ${ARROW_BUNDLED_STATIC_LIBS} PARENT_SCOPE) ``` ########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -913,7 +928,7 @@ set(EP_COMMON_CMAKE_ARGS -DCMAKE_C_FLAGS_MISIZEREL=${EP_C_FLAGS_MINSIZEREL} -DCMAKE_C_FLAGS_RELEASE=${EP_C_FLAGS_RELEASE} -DCMAKE_C_FLAGS_RELWITHDEBINFO=${EP_C_FLAGS_RELWITHDEBINFO} - -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=${CMAKE_EXPORT_NO_PACKAGE_REGISTRY} + -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON Review Comment: Revert a needless change. ```suggestion -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=${CMAKE_EXPORT_NO_PACKAGE_REGISTRY} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
