zinking commented on code in PR #36967: URL: https://github.com/apache/arrow/pull/36967#discussion_r1303829093
########## cpp/src/arrow/dataset/scanner.h: ########## @@ -55,6 +55,7 @@ constexpr int64_t kDefaultBatchSize = 1 << 17; // 128Ki rows constexpr int32_t kDefaultBatchReadahead = 16; constexpr int32_t kDefaultFragmentReadahead = 4; constexpr int32_t kDefaultBytesReadahead = 1 << 25; // 32MiB +constexpr int64_t kDefaultStartOffset = -1; Review Comment: > Well, why not simply 0? Isn't starting from 0 the default behavior? because 0 is a correct value set. I am using -1 to indicate that this parameter is not set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
