Light-City commented on PR #37243:
URL: https://github.com/apache/arrow/pull/37243#issuecomment-1691042055
> In the current implementation, the overflow problem is not considered
just like:
```
func = std::make_shared<ScalarAggregateFunction>("sum", Arity::Unary(),
sum_doc,
&default_scalar_aggregate_options);
AddArrayScalarAggKernels(SumInit, {boolean()}, uint64(), func.get());
AddAggKernel(KernelSignature::Make({Type::DECIMAL128}, FirstType),
SumInit, func.get(),
SimdLevel::NONE);
AddAggKernel(KernelSignature::Make({Type::DECIMAL256}, FirstType),
SumInit, func.get(),
SimdLevel::NONE);
AddArrayScalarAggKernels(SumInit, SignedIntTypes(), int64(), func.get());
```
sum(int64)-> output also is int64(), will cause overflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
