gordonwang0 commented on code in PR #4714:
URL: https://github.com/apache/arrow-rs/pull/4714#discussion_r1304573569


##########
object_store/src/aws/mod.rs:
##########
@@ -946,6 +946,23 @@ impl AmazonS3Builder {
         self
     }
 
+    /// Set a trusted proxy CA certificate
+    pub fn with_proxy_ca_certificate(

Review Comment:
   I added them to the builder because the existing `with_proxy_url` was part 
of the builder. I think it makes sense to keep all proxy options on the same 
struct, but I don't have a strong opinion on this. Do you think it's better to 
move it to ClientConfig?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to