austinzh commented on issue #34118:
URL: https://github.com/apache/arrow/issues/34118#issuecomment-1692645100
I add a compile check in the s3fs.cc and found out that the ubuntu_cpp and
also the python manylinux build both failed if I add following code
```
#ifndef ARROW_S3_HAS_CRT
#error "ARROW_S3_HAS_CRT does not exist"
#endif
```
Here is my build script to trigger this error.
```
archery docker run --env CMAKE_BUILD_TYPE=release
python-wheel-manylinux-2014
```
I have to do following patch to remove the precompile marco
```diff
diff -r arrow/cpp/src/arrow/CMakeLists.txt
apache-arrow-12.0.1/cpp/src/arrow/CMakeLists.txt
488,497d487
< try_compile(S3_HAS_CRT ${CMAKE_CURRENT_BINARY_DIR}/try_compile
< SOURCES
"${CMAKE_CURRENT_SOURCE_DIR}/filesystem/try_compile/check_s3fs_crt.cc"
< CMAKE_FLAGS
"-DINCLUDE_DIRECTORIES=${CURRENT_INCLUDE_DIRECTORIES}"
< LINK_LIBRARIES ${AWSSDK_LINK_LIBRARIES} CXX_STANDARD 17)
<
< if(S3_HAS_CRT)
< message(STATUS "AWS SDK is new enough to have CRT support")
< add_definitions(-DARROW_S3_HAS_CRT)
< endif()
<
diff -r arrow/cpp/src/arrow/filesystem/s3fs.cc
apache-arrow-12.0.1/cpp/src/arrow/filesystem/s3fs.cc
54d53
< #ifdef ARROW_S3_HAS_CRT
58d56
< #endif
2629d2626
< #ifdef ARROW_S3_HAS_CRT
2641d2637
< #endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
