sarutak commented on code in PR #7403: URL: https://github.com/apache/arrow-datafusion/pull/7403#discussion_r1305276619
########## datafusion/sqllogictest/test_files/math.slt: ########## @@ -95,10 +95,10 @@ SELECT atan2(2.0, 1.0), atan2(-2.0, 1.0), atan2(2.0, -1.0), atan2(-2.0, -1.0), a 1.107148717794 -1.107148717794 2.034443935796 -2.034443935796 NULL NULL NULL # nanvl -query RRR -SELECT nanvl(asin(10), 1.0), nanvl(1.0, 2.0), nanvl(asin(10), asin(10)) +query RRB +SELECT nanvl(asin(10), 1.0), nanvl(1.0, 2.0), isnan(nanvl(asin(10), asin(10))) Review Comment: The sign of `NaN` returned by `asin(10)` seems different between operating systems. On Linus, `NaN` is returned but `-NaN` on macOS and WIndows. https://github.com/apache/arrow-datafusion/actions/runs/5971983397/job/16201846083#step:5:5969 https://github.com/apache/arrow-datafusion/actions/runs/5971983397/job/16201846201#step:5:6058 So, I use `isnan` just to check if it's `NaN` or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
