Dandandan commented on a change in pull request #9070:
URL: https://github.com/apache/arrow/pull/9070#discussion_r550959182
##########
File path: rust/datafusion/src/physical_plan/hash_join.rs
##########
@@ -479,37 +490,40 @@ fn build_batch(
fn build_join_indexes(
left: &JoinHashMap,
right: &RecordBatch,
- join_type: &JoinType,
+ join_type: JoinType,
right_on: &HashSet<String>,
-) -> Result<Vec<(JoinIndex, RightIndex)>> {
+) -> Result<(UInt64Array, UInt32Array)> {
let keys_values = right_on
.iter()
.map(|name|
Ok(col(name).evaluate(right)?.into_array(right.num_rows())))
.collect::<Result<Vec<_>>>()?;
let mut key = Vec::with_capacity(keys_values.len());
+ let mut left_indices = UInt64Builder::new(0);
Review comment:
Seems better for inner join to *not* use builder / allocate bitmap for
nulls? What is the current most ergonomic way to do this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
