alamb commented on code in PR #7282:
URL: https://github.com/apache/arrow-datafusion/pull/7282#discussion_r1305930941
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -218,21 +132,6 @@ macro_rules! compute_utf8_op {
}};
}
-/// Invoke a compute kernel on a pair of binary data arrays
-macro_rules! compute_binary_op {
- ($LEFT:expr, $RIGHT:expr, $OP:ident, $DT:ident) => {{
- let ll = $LEFT
- .as_any()
- .downcast_ref::<$DT>()
- .expect("compute_op failed to downcast left side array");
- let rr = $RIGHT
- .as_any()
- .downcast_ref::<$DT>()
- .expect("compute_op failed to downcast right side array");
- Ok(Arc::new(paste::expr! {[<$OP _binary>]}(&ll, &rr)?))
- }};
-}
-
/// Invoke a compute kernel on a data array and a scalar value
macro_rules! compute_utf8_op_scalar {
Review Comment:
And then implement `Datum` directly for `ColumnarValue` as well 🤔 that
would be pretty sweet
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -218,21 +132,6 @@ macro_rules! compute_utf8_op {
}};
}
-/// Invoke a compute kernel on a pair of binary data arrays
-macro_rules! compute_binary_op {
- ($LEFT:expr, $RIGHT:expr, $OP:ident, $DT:ident) => {{
- let ll = $LEFT
- .as_any()
- .downcast_ref::<$DT>()
- .expect("compute_op failed to downcast left side array");
- let rr = $RIGHT
- .as_any()
- .downcast_ref::<$DT>()
- .expect("compute_op failed to downcast right side array");
- Ok(Arc::new(paste::expr! {[<$OP _binary>]}(&ll, &rr)?))
- }};
-}
-
/// Invoke a compute kernel on a data array and a scalar value
macro_rules! compute_utf8_op_scalar {
Review Comment:
And then implement `Datum` directly for `ColumnarValue` as well 🤔 that
would be pretty sweet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
