mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r550990445
##########
File path: cpp/src/arrow/adapters/orc/adapter_test.cc
##########
@@ -157,4 +217,15960 @@ TEST(TestAdapter, readIntAndStringFileMultipleStripes) {
EXPECT_TRUE(stripe_reader->ReadNext(&record_batch).ok());
}
}
+
+// Arrow2ORC type converter tests
+
+TEST(TestAdapterWriteConverter, typeBool) {
+ DataType* type = boolean().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::BOOLEAN);
+}
+TEST(TestAdapterWriteConverter, typeInt8) {
+ DataType* type = int8().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::BYTE);
+}
+TEST(TestAdapterWriteConverter, typeInt16) {
+ DataType* type = int16().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::SHORT);
+}
+TEST(TestAdapterWriteConverter, typeInt32) {
+ DataType* type = int32().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::INT);
+}
+TEST(TestAdapterWriteConverter, typeInt64) {
+ DataType* type = int64().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::LONG);
+}
+TEST(TestAdapterWriteConverter, typeFloat) {
+ DataType* type = float32().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::FLOAT);
+}
+TEST(TestAdapterWriteConverter, typeDouble) {
+ DataType* type = float64().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::DOUBLE);
+}
+TEST(TestAdapterWriteConverter, typeString) {
+ DataType* type = utf8().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::STRING);
+}
+TEST(TestAdapterWriteConverter, typeLargeString) {
+ DataType* type = large_utf8().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::STRING);
+}
+TEST(TestAdapterWriteConverter, typeBinary) {
+ DataType* type = binary().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::BINARY);
+}
+TEST(TestAdapterWriteConverter, typeLargeBinary) {
+ DataType* type = large_binary().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::BINARY);
+}
+TEST(TestAdapterWriteConverter, typeFixedSizeBinary) {
+ DataType* type = fixed_size_binary(3).get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::BINARY);
+}
+TEST(TestAdapterWriteConverter, typeFixedSizeBinaryZero) {
+ DataType* type = fixed_size_binary(0).get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::BINARY);
+}
+TEST(TestAdapterWriteConverter, typeDate32) {
+ DataType* type = date32().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::DATE);
+}
+TEST(TestAdapterWriteConverter, typeDate64) {
+ DataType* type = date64().get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::TIMESTAMP);
+}
+TEST(TestAdapterWriteConverter, typeTimestampSecond) {
+ DataType* type = timestamp(TimeUnit::type::SECOND).get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::TIMESTAMP);
+}
+TEST(TestAdapterWriteConverter, typeTimestampMilli) {
+ DataType* type = timestamp(TimeUnit::type::MILLI).get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::TIMESTAMP);
+}
+TEST(TestAdapterWriteConverter, typeTimestampMicro) {
+ DataType* type = timestamp(TimeUnit::type::MICRO).get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::TIMESTAMP);
+}
+TEST(TestAdapterWriteConverter, typeTimestampNano) {
+ DataType* type = timestamp(TimeUnit::type::NANO).get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::TIMESTAMP);
+}
+TEST(TestAdapterWriteConverter, typeDecimal) {
+ DataType* type = decimal(32, 5).get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::DECIMAL);
+ EXPECT_EQ(out->getPrecision(), 32);
+ EXPECT_EQ(out->getScale(), 5);
+}
+TEST(TestAdapterWriteConverter, typeList) {
+ auto sharedPtrArrowType = list(std::make_shared<Field>("a", int32()));
+ DataType* type = sharedPtrArrowType.get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getSubtypeCount(), 1);
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::LIST);
+ EXPECT_EQ(out->getSubtype(0)->getKind(), liborc::TypeKind::INT);
+}
+TEST(TestAdapterWriteConverter, typeLargeList) {
+ auto sharedPtrArrowType = large_list(std::make_shared<Field>("a", int32()));
+ DataType* type = sharedPtrArrowType.get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getSubtypeCount(), 1);
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::LIST);
+ EXPECT_EQ(out->getSubtype(0)->getKind(), liborc::TypeKind::INT);
+}
+TEST(TestAdapterWriteConverter, typeFixedSizeList) {
+ auto sharedPtrArrowType = fixed_size_list(std::make_shared<Field>("a",
int32()), 3);
+ DataType* type = sharedPtrArrowType.get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getSubtypeCount(), 1);
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::LIST);
+ EXPECT_EQ(out->getSubtype(0)->getKind(), liborc::TypeKind::INT);
+}
+TEST(TestAdapterWriteConverter, typeFixedSizeListZero) {
+ auto sharedPtrArrowType = fixed_size_list(std::make_shared<Field>("a",
int32()), 0);
+ DataType* type = sharedPtrArrowType.get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getSubtypeCount(), 1);
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::LIST);
+ EXPECT_EQ(out->getSubtype(0)->getKind(), liborc::TypeKind::INT);
+}
+TEST(TestAdapterWriteConverter, typeStructTrivial) {
+ std::vector<std::shared_ptr<Field>> xFields;
+ auto sharedPtrArrowType = struct_(xFields);
+ DataType* type = sharedPtrArrowType.get();
+ ORC_UNIQUE_PTR<liborc::Type> out;
+ (void)(adapters::orc::GetORCType(type, &out));
+ EXPECT_EQ(out->getSubtypeCount(), 0);
+ EXPECT_EQ(out->getKind(), liborc::TypeKind::STRUCT);
+}
+TEST(TestAdapterWriteConverter, typeStructSingleton) {
+ std::vector<std::shared_ptr<Field>> xFields;
+ xFields.push_back(std::make_shared<Field>("a", utf8()));
Review comment:
Thanks! I have done that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
