devinjdangelo commented on PR #7390: URL: https://github.com/apache/arrow-datafusion/pull/7390#issuecomment-1695652149
Thanks @alamb! I just pushed up some updates addressing review comments and adding a few more tests. The main thing remaining is unit tests which set options via a `StatementOptions` struct and inspect the resulting `FileTypeWriterOptions` to ensure the settings actually were set as expected. The current sqllogictests are only ensuring that passing the option does not result in an error, not that the setting actually had an effect on the underlying `RecordBatchWriter`. I expect to get back to work on unit tests later today (after 5pm EST). Feel free to take a crack at it before I get to it (or just enjoy your vacation)! Also noticed many clippy warnings locally unrelated to the changes in this PR. I believe that is related to the clippy updates upstream, so may just need to merge main again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
