jhorstmann commented on pull request #8882: URL: https://github.com/apache/arrow/pull/8882#issuecomment-753647897
@Dandandan there is another implementation of float comparison in use for lexicographical ordering (sorting by multiple columns) in `ord.rs`. That would also need to be updated to be consistent. Ideally the `min`/`max` kernels would also follow the same ordering. For the simd implementations that could be tricky because they currently delegate all types to the packed_simd `lt` implementation. I didn't have time to look into it in more detail yet. In my understanding, the only difference in behaviour should be around negative NaN and that small difference shouldn't block this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
