felipecrv commented on code in PR #35628:
URL: https://github.com/apache/arrow/pull/35628#discussion_r1307418106
##########
cpp/src/parquet/statistics.cc:
##########
@@ -437,6 +437,10 @@ std::pair<ByteArray, ByteArray> GetMinMaxBinaryHelper(
if (::arrow::is_binary_like(values.type_id())) {
::arrow::VisitArraySpanInline<::arrow::BinaryType>(
*values.data(), std::move(valid_func), std::move(null_func));
+ } else if (values.type_id() == ::arrow::Type::BINARY_VIEW ||
+ values.type_id() == ::arrow::Type::STRING_VIEW) {
+ ::arrow::VisitArraySpanInline<::arrow::BinaryViewType>(
Review Comment:
Refer to this graph to visualize how this would fit among the existing
predicates.
https://gist.github.com/felipecrv/3c02f3784221d946dec1b031c6d400db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
