andygrove commented on a change in pull request #9064:
URL: https://github.com/apache/arrow/pull/9064#discussion_r551040361
##########
File path: rust/datafusion/src/datasource/parquet.rs
##########
@@ -62,17 +64,37 @@ impl TableProvider for ParquetTable {
self.schema.clone()
}
+ fn supports_filter_pushdown(
+ &self,
+ _filter: &Expr,
+ ) -> Result<TableProviderFilterPushDown> {
+ Ok(TableProviderFilterPushDown::Inexact)
+ }
+
/// Scan the file(s), using the provided projection, and return one
BatchIterator per
/// partition.
fn scan(
&self,
projection: &Option<Vec<usize>>,
batch_size: usize,
- _filters: &[Expr],
+ filters: &[Expr],
) -> Result<Arc<dyn ExecutionPlan>> {
+ let predicate = if filters.is_empty() {
+ None
+ } else {
+ Some(
+ filters
Review comment:
Immediately after posting that comment I see how it works now, but I
think a comment would still be helpful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
