Light-City commented on code in PR #37171:
URL: https://github.com/apache/arrow/pull/37171#discussion_r1308113118
##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -521,4 +521,35 @@ TEST_F(TestRecordBatchReader, ToTable) {
ASSERT_EQ(table->column(0)->chunks().size(), 0);
}
+TEST_F(TestRecordBatch, RewriteSchema) {
+ const int length = 10;
+
+ auto f0 = field("f0", int32());
+ auto f1 = field("f1", uint8());
+ auto f2 = field("f2", int16());
+ auto f3 = field("f3", int8());
+
+ auto schema = ::arrow::schema({f0, f1, f2});
+
+ random::RandomArrayGenerator gen(42);
+
+ auto a0 = gen.ArrayOf(int32(), length);
+ auto a1 = gen.ArrayOf(uint8(), length);
+ auto a2 = gen.ArrayOf(int16(), length);
+
+ auto b1 = RecordBatch::Make(schema, length, {a0, a1, a2});
+
+ f0 = field("fd0", int32());
+ f1 = field("fd1", uint8());
+ f2 = field("fd2", int16());
+
+ schema = ::arrow::schema({f0, f1, f2});
+ ASSERT_OK_AND_ASSIGN(auto mutated, b1->RewriteSchema(schema));
+ auto expected = RecordBatch::Make(schema, length, b1->columns());
+ ASSERT_TRUE(mutated->Equals(*expected));
+
+ schema = ::arrow::schema({f0, f1, f3});
+ ASSERT_RAISES(Invalid, b1->RewriteSchema(schema));
Review Comment:
It's not covered, I'll add it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
