alexander-beedie commented on issue #1000:
URL: https://github.com/apache/arrow-adbc/issues/1000#issuecomment-1697652605

   Curious why the same issue doesn't hit the PostgreSQL driver (I just 
tested); maybe some parsing/quoting logic can be lifted from there?
   
   I'm not sure that quoting table names by default is a good idea though (or 
at least not those containing "."), as access to `main` and `temp` (which are 
always available/valid), and any other names established by `ATTACH DATABASE` 
is fundamental, whereas creating actual tables containing a "." in the name is 
merely A Very Bad Idea™ ;)
   
   You can determine recognised database names in SQLite using `PRAGMA 
database_list` or "SELECT * FROM pragma_database_list" (I don't _think_ the C 
API offers an equivalent function). Perhaps use that to determine what is/isn't 
a db prefix and require the user to quote if they really have managed to create 
a standalone column called "main.something".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to