tustvold commented on code in PR #4739:
URL: https://github.com/apache/arrow-rs/pull/4739#discussion_r1309083291
##########
arrow-ord/src/comparison.rs:
##########
@@ -1548,79 +1547,228 @@ mod tests {
};
}
- #[test]
- fn test_primitive_array_eq() {
- cmp_i64!(
- eq,
- eq_dyn,
- vec![8, 8, 8, 8, 8, 8, 8, 8, 8, 8],
- vec![6, 7, 8, 9, 10, 6, 7, 8, 9, 10],
- vec![false, false, true, false, false, false, false, true, false,
false]
- );
+ macro_rules! test_array_scalar_op {
Review Comment:
I know there were test macros before, but perhaps we could take the
opportunity to remove them. I find it really hard to follow what these tests
are doing now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
