adamreeve commented on issue #37453:
URL: https://github.com/apache/arrow/issues/37453#issuecomment-1698496399
Hi @mapleFU, no we haven't enabled the page index and we aren't using
DATA_PAGE_V2, but I don't think your comment is correct, `page_index_enabled`
is called when data page V2 is not used, as there is an OR condition:
```
bool pages_change_on_record_boundaries() const {
return properties_->data_page_version() == ParquetDataPageVersion::V2 ||
properties_->page_index_enabled(descr_->path());
}
```
I have tested a fix that moves the calculation of this to the constructor
and that fixes the performance regression, so I was planning on making a PR for
this soon but was just working on getting the tests to run locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
