jorisvandenbossche commented on code in PR #37450:
URL: https://github.com/apache/arrow/pull/37450#discussion_r1309899609


##########
python/pyarrow/tests/test_substrait.py:
##########
@@ -928,11 +933,12 @@ def table_provider(names, _):
 
 
 @pytest.mark.parametrize("expr", [
-    pc.equal(ds.field("x"), 7),
-    pc.equal(ds.field("x"), ds.field("y")),
-    ds.field("x") > 50
+    "pc.equal(ds.field('x'), 7)",
+    "pc.equal(ds.field('x'), ds.field('y'))",
+    "ds.field('x') > 50"
 ])
 def test_serializing_expressions(expr):
+    expr = eval(expr)

Review Comment:
   ```suggestion
       pc.equal(pc.field('x'), 7)",
       pc.equal(pc.field('x'), pc.field('y'))",
       pc.field('x') > 50"
   ])
   def test_serializing_expressions(expr):
   ```
   
   The `field` nowadays lives in `pyarrow.compute` (it's only still exposed 
through `pyarrow.dataset` as well for back compat), but so can be imported from 
there and is always available at the moment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to