mapleFU commented on code in PR #37461:
URL: https://github.com/apache/arrow/pull/37461#discussion_r1310243347
##########
cpp/src/parquet/page_index.cc:
##########
@@ -88,9 +88,8 @@ class TypedColumnIndexImpl : public TypedColumnIndex<DType> {
public:
using T = typename DType::c_type;
- TypedColumnIndexImpl(const ColumnDescriptor& descr,
- const format::ColumnIndex& column_index)
- : column_index_(column_index) {
+ TypedColumnIndexImpl(const ColumnDescriptor& descr, format::ColumnIndex
column_index)
+ : column_index_(std::move(column_index)) {
Review Comment:
But I think if we have many row-groups and column chunks, during building,
it can using `move` instead of `copy` to avoid some memcpy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
