tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1310403498
##########
python/CMakeLists.txt:
##########
@@ -336,6 +343,8 @@ if(PYARROW_BUILD_PARQUET_ENCRYPTION)
else()
message(FATAL_ERROR "You must build Arrow C++ with
PARQUET_REQUIRE_ENCRYPTION=ON")
endif()
+else()
+ set(CYTHON_COMPILE_TIME_ENV "PARQUET_ENCRYPTION_ENABLED=0")
endif()
Review Comment:
I looked into this and found an issue. It looks like the way other
parameters are being added creates a list. This causes each parameter to be
separated by a ";". which wont work for what I need to do.
Example output:
CYTHON_FLAGS: ;-E PARQUET_ENCRYPTION_ENABLED=0;--warning-errors
This is due to the way items are added:
set(CYTHON_FLAGS "${CYTHON_FLAGS}" "--warning-errors")
instead of
set(CYTHON_FLAGS "${CYTHON_FLAGS} --warning-errors")
For now I'll keep things as I have them unless you have another idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
