kkraus14 commented on code in PR #37365:
URL: https://github.com/apache/arrow/pull/37365#discussion_r1310457691
##########
cpp/src/arrow/gpu/cuda_context.h:
##########
@@ -140,6 +142,71 @@ class ARROW_EXPORT CudaDevice : public Device {
/// \param[in] size The buffer size in bytes
Result<std::shared_ptr<CudaHostBuffer>> AllocateHostBuffer(int64_t size);
+ /// \brief EXPERIMENTAL: Wrapper for CUstreams
+ ///
+ /// Does not *own* the CUstream object which must be separately constructed
+ /// and freed using cuStreamCreate and cuStreamDestroy (or equivalent).
+ /// Default construction will use the cuda default stream, and does not allow
+ /// construction from literal 0 or nullptr.
+ class ARROW_EXPORT Stream : public Device::Stream {
+ public:
+ explicit Stream(std::shared_ptr<CudaContext> ctx) noexcept
+ : context_{std::move(ctx)}, stream_{} {}
+
+ ~Stream() = default;
+ explicit Stream(std::shared_ptr<CudaContext> ctx, CUstream stream) noexcept
+ : context_{std::move(ctx)}, stream_{stream} {}
Review Comment:
What's the issue with someone using `Stream::WrapStream` and passing
`nullptr` if they don't want any lifetime management or handling something like
a shared pointer in a release function if desired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
