tustvold commented on code in PR #4751:
URL: https://github.com/apache/arrow-rs/pull/4751#discussion_r1310460013
##########
arrow/src/pyarrow.rs:
##########
@@ -277,10 +278,19 @@ impl FromPyArrow for ArrowArrayStreamReader {
}
}
-impl IntoPyArrow for ArrowArrayStreamReader {
+impl FromPyArrow for Box<dyn RecordBatchReader + Send> {
Review Comment:
I'm guessing this is necessary because RecordBatchReader is a foreign trait,
and so we can't provide a blanket impl as `RecordBatchReader` could be
implemeneted for `Vec` or something silly. As you say it ultimately makes no
difference as we end up boxing anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
