danepitkin commented on code in PR #37097: URL: https://github.com/apache/arrow/pull/37097#discussion_r1310700873
########## python/pyarrow/includes/libarrow_fs.pxd: ########## @@ -23,7 +23,7 @@ from pyarrow.includes.libarrow_python cimport CTimePoint cdef extern from "arrow/filesystem/api.h" namespace "arrow::fs" nogil: - ctypedef enum CFileType "arrow::fs::FileType": + ctypedef enum CFileType "arrow::fs::FileType": # numpydoc ignore=PR01 Review Comment: > BTW, on the latest commit, `FileSystemDataset.from_paths` isn't erroring anymore, so maybe the change from classmethod to staticmethod "fixed" it .. I noticed that, too! There's some weird stuff going on here with parsing. This change shouldn't have mattered. For the enums, it seems numpydoc just doesn't parse properly. It's getting the Enum class function signature, but it should really be documenting the values. I don't see any reference to the word "enum" in numpydocs documentation so I'll assume it is unsupported. I can skip enum validation in archery numpydoc. ``` >>> inspect.signature(pa.MetadataVersion) <Signature (value, names=None, *, module=None, qualname=None, type=None, start=1, boundary=None)> >>> inspect.signature(Flag) <Signature (value, names=None, *, module=None, qualname=None, type=None, start=1, boundary=None)> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
