zeroshade commented on code in PR #37468:
URL: https://github.com/apache/arrow/pull/37468#discussion_r1310781814
##########
go/arrow/array/list_test.go:
##########
@@ -30,12 +30,15 @@ func TestListArray(t *testing.T) {
tests := []struct {
typeID arrow.Type
offsets interface{}
+ sizes interface{}
dt arrow.DataType
}{
- {arrow.LIST, []int32{0, 3, 3, 3, 7},
arrow.ListOf(arrow.PrimitiveTypes.Int32)},
- {arrow.LARGE_LIST, []int64{0, 3, 3, 3, 7},
arrow.LargeListOf(arrow.PrimitiveTypes.Int32)},
- {arrow.LIST, []int32{0, 3, 3, 3, 7},
arrow.ListOfField(arrow.Field{Name: "item", Type: arrow.PrimitiveTypes.Int32,
Nullable: true})},
- {arrow.LARGE_LIST, []int64{0, 3, 3, 3, 7},
arrow.LargeListOfField(arrow.Field{Name: "item", Type:
arrow.PrimitiveTypes.Int32, Nullable: true})},
+ {arrow.LIST, []int32{0, 3, 3, 3, 7}, nil,
arrow.ListOf(arrow.PrimitiveTypes.Int32)},
+ {arrow.LARGE_LIST, []int64{0, 3, 3, 3, 7}, nil,
arrow.LargeListOf(arrow.PrimitiveTypes.Int32)},
+ {arrow.LIST, []int32{0, 3, 3, 3, 7}, nil,
arrow.ListOfField(arrow.Field{Name: "item", Type: arrow.PrimitiveTypes.Int32,
Nullable: true})},
+ {arrow.LARGE_LIST, []int64{0, 3, 3, 3, 7}, nil,
arrow.LargeListOfField(arrow.Field{Name: "item", Type:
arrow.PrimitiveTypes.Int32, Nullable: true})},
+ {arrow.LIST_VIEW, []int32{0, 3, 3, 3}, []int32{3, 0, 0, 4},
arrow.ListViewOf(arrow.PrimitiveTypes.Int32)},
+ {arrow.LARGE_LIST_VIEW, []int64{0, 3, 3, 3}, []int64{3, 0, 0,
4}, arrow.LargeListViewOf(arrow.PrimitiveTypes.Int32)},
}
Review Comment:
can we test with offsets that are out of order (as that would be a reason to
use list view over list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
