zeroshade commented on issue #35775: URL: https://github.com/apache/arrow/issues/35775#issuecomment-1699810703
@tschaub I think it would be fine to create a backwards incompatible change here (as long as we mark the PR appropriately). While a non-breaking change would always be preferred (such as creating a new function instead of changing the existing one) it's not a deal breaker on this. > I'm unclear on why the FileMetadata and KeyValueMetadata fields are exported on the file.Writer struct (but I'm probably missing other uses for both of these fields). Are these meant to settable before the writer is closed? Or should there be an explicit writer.SetKeyValueMetadata() method that would be called before closing a writer (somewhat similar to https://github.com/segmentio/parquet-go/pull/399). You are exactly correct, they were meant to be settable before the writer is closed as `Finish` / `Close` is where the metadata gets written so they can be set / updated anytime before the writer is closed when it will actually *write* the metadata. I think it's reasonable to change these to be no longer exported and add a `SetKeyValueMetadata` method if everyone thinks this would be a better API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
