sgilmore10 opened a new pull request, #37482:
URL: https://github.com/apache/arrow/pull/37482
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Per https://github.com/apache/arrow/pull/37475#discussion_r1310732596, we
should consider adding a name-value pair like `AllowNonScalar = true | false`
to the `arrow.internal.validate.index.*` validation functions since it is
relatively common to want to explicitly allow (or disallow) non-scalar inputs
to indexing functions (e.g. the `column` method of `RecordBatch` should only
support scalar index values).
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
1. Modified all functions within the `arrow.internal.valdiate.index` package
(i.e. `numeric()`, `string()`, and `numericOrString()`) to accept a name-value
pair called `AllowNonNumeric`. This name-value pair can be set to `logical`
scalar, and by default it's set to `true`.
2. Updated the `column()` method in `RecordBatch` to pass
`AllowNonNumeric=false` to `numericOrString()`.
3. Updated the `field()` method in `RecordBatch` to pass
`AllowNonNumeric=false` to `numericOrString()`.
### Are these changes tested?
Yes. Added new test cases to `tNumeric.m`, `tString.m` and
`tNumericOrString.m`
### Are there any user-facing changes?
No.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line
below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
