pitrou commented on code in PR #37412:
URL: https://github.com/apache/arrow/pull/37412#discussion_r1311788943
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -470,6 +470,16 @@ takes precedence over ccache if a storage backend is
configured" ON)
"Rely on jemalloc shared libraries where relevant"
${ARROW_DEPENDENCY_USE_SHARED})
+ if(MSVC)
+ # It seems that conda's llvmdev for Windows doesn't provide shared
+ # library.
+ set(ARROW_LLVM_USE_SHARED_DEFAULT OFF)
Review Comment:
Hmm, I don't think we should change this for conda. Instead, conda users on
Windows will have to explicitly pass `-DARROW_LLVM_USE_SHARED=OFF`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
