pitrou commented on a change in pull request #8955:
URL: https://github.com/apache/arrow/pull/8955#discussion_r551389414
##########
File path: cpp/src/arrow/util/decimal_test.cc
##########
@@ -169,6 +169,11 @@ TEST(DecimalTest, TestDecimalStringAndBytesRoundTrip) {
ASSERT_EQ(expected, result);
}
+TEST(DecimalTest, TestOverflow) {
+ std::string invalid_value("1e100");
Review comment:
Also test a negative exponent and boundary values such as 38 and -38?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
