JayjeetAtGithub commented on PR #7401: URL: https://github.com/apache/arrow-datafusion/pull/7401#issuecomment-1702094120
> Left some comments, I think it would also be good to check the benchmarks to see how this impacts performance @tustvold I benchmarked the current implementation of `CardinalityAwareRowConverter` with `RowConverter` and didn't see any performance regression. See the results [here](https://github.com/JayjeetAtGithub/iox_observe_bench/blob/main/docs/bench.md#benchmarking-row-conversion-on-low-and-high-cardinality-dicts-w-dict-preserving). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
