sarutak commented on code in PR #7462: URL: https://github.com/apache/arrow-datafusion/pull/7462#discussion_r1313414261
########## datafusion/sqllogictest/test_files/select.slt: ########## @@ -224,12 +224,6 @@ select ---- false true false true true false false true false true true false true true false false true -# select NaNs -query RRRR -select 'NaN'::double a, '-NaN'::double b, 'NaN'::float c, '-NaN'::float d ----- -NaN -NaN NaN -NaN Review Comment: I don't think so. I believe `NaN` and `-NaN` are finally parsed [here](https://github.com/Alexhuszagh/rust-lexical/blob/main/lexical-parse-float/src/parse.rs#L929). So, as long as `f32::NAN`, `f64::NAN`, `-f32::NAN` and `-f64::NAN` follows IEEE 754, simple literals should not be impacted. But the [string representation needs to be `NaN` regardless of `NaN` or `-NaN`](https://github.com/apache/arrow-datafusion/pull/7462/files#diff-4a5281b565761d7b0e1a53c80a44c3ef00d17855b418a39ddf4ceaef7230e46cR46). So this test should be changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
