tustvold commented on PR #3558: URL: https://github.com/apache/arrow-rs/pull/3558#issuecomment-1703335832
With the changes in https://github.com/apache/arrow-rs/pull/3558/commits/c2d40092cbf41f8cf0838b2239ec8392017da6d3 there is no longer a performance regression, except when re-encoding ``` interleave dict(20, 0.0) 100 [0..100, 100..230, 450..1000] time: [2.7514 µs 2.7549 µs 2.7582 µs] change: [+0.2105% +0.4287% +0.7010%] (p = 0.00 < 0.05) Change within noise threshold. Found 3 outliers among 100 measurements (3.00%) 1 (1.00%) low mild 1 (1.00%) high mild 1 (1.00%) high severe interleave dict(20, 0.0) 400 [0..100, 100..230, 450..1000] time: [5.7040 µs 5.7069 µs 5.7101 µs] change: [-7.1155% -6.8505% -6.5598%] (p = 0.00 < 0.05) Performance has improved. Found 4 outliers among 100 measurements (4.00%) 2 (2.00%) high mild 2 (2.00%) high severe interleave dict(20, 0.0) 1024 [0..100, 100..230, 450..1000] time: [11.952 µs 11.958 µs 11.964 µs] change: [-10.702% -10.503% -10.379%] (p = 0.00 < 0.05) Performance has improved. Found 5 outliers among 100 measurements (5.00%) 4 (4.00%) high mild 1 (1.00%) high severe interleave dict(20, 0.0) 1024 [0..100, 100..230, 450..1000, 0..1000] time: [12.001 µs 12.006 µs 12.011 µs] change: [-12.141% -11.932% -11.799%] (p = 0.00 < 0.05) Performance has improved. Found 7 outliers among 100 measurements (7.00%) 6 (6.00%) high mild 1 (1.00%) high severe interleave dict_sparse(20, 0.0) 100 [0..100, 100..230, 450..1000] time: [2.7432 µs 2.7468 µs 2.7506 µs] change: [-1.5949% -1.2917% -0.9539%] (p = 0.00 < 0.05) Change within noise threshold. Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high severe interleave dict_sparse(20, 0.0) 400 [0..100, 100..230, 450..1000] time: [5.6984 µs 5.7024 µs 5.7064 µs] change: [-6.7690% -6.4981% -6.2229%] (p = 0.00 < 0.05) Performance has improved. Found 5 outliers among 100 measurements (5.00%) 4 (4.00%) high mild 1 (1.00%) high severe interleave dict_sparse(20, 0.0) 1024 [0..100, 100..230, 450..1000] time: [12.065 µs 12.071 µs 12.077 µs] change: [-10.666% -10.329% -10.110%] (p = 0.00 < 0.05) Performance has improved. Found 5 outliers among 100 measurements (5.00%) 1 (1.00%) high mild 4 (4.00%) high severe interleave dict_sparse(20, 0.0) 1024 [0..100, 100..230, 450..1000, 0..1000] time: [11.995 µs 12.000 µs 12.007 µs] change: [-12.334% -12.126% -11.999%] (p = 0.00 < 0.05) Performance has improved. Found 8 outliers among 100 measurements (8.00%) 1 (1.00%) low mild 5 (5.00%) high mild 2 (2.00%) high severe interleave dict_distinct 100 time: [4.9384 µs 4.9423 µs 4.9467 µs] change: [-10.644% -10.405% -10.218%] (p = 0.00 < 0.05) Performance has improved. Found 5 outliers among 100 measurements (5.00%) 4 (4.00%) high mild 1 (1.00%) high severe interleave dict_distinct 1024 time: [4.8532 µs 4.8597 µs 4.8655 µs] change: [-12.302% -12.073% -11.862%] (p = 0.00 < 0.05) Performance has improved. Found 2 outliers among 100 measurements (2.00%) 1 (1.00%) high mild 1 (1.00%) high severe interleave dict_distinct 2048 time: [4.8942 µs 4.9006 µs 4.9081 µs] change: [-11.126% -10.785% -10.446%] (p = 0.00 < 0.05) Performance has improved. Found 3 outliers among 100 measurements (3.00%) 1 (1.00%) high mild 2 (2.00%) high severe ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
