ritchie46 commented on issue #4764: URL: https://github.com/apache/arrow-rs/issues/4764#issuecomment-1704670097
I did some `--timings --release` builds on #4765 | master | feature | perc | |-----------|------------|---------| | 58.54 | 42.12 | 73% | | 42.6 | 33.8 | 79% | | 59.9 | 38.6 | 56% | There are some significant savings with some trivial features. Indeed as you said `arrow-select` and `arrow-cast` are the big boys. But I expect that by feature gating some code out we send much less code to the linker. I understand your hesitation about feature gating, but I'd argue not all are the same. Some feature gates very naturally fit the code order and can gate entire modules. It can save a lot of cumulative compile times for downstream users. :) For the planet! :wink: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
