tustvold commented on code in PR #4765:
URL: https://github.com/apache/arrow-rs/pull/4765#discussion_r1314815756


##########
parquet/Cargo.toml:
##########
@@ -42,7 +42,7 @@ arrow-csv = { workspace = true, optional = true }
 arrow-data = { workspace = true, optional = true }
 arrow-schema = { workspace = true, optional = true }
 arrow-select = { workspace = true, optional = true }
-arrow-ipc = { workspace = true, optional = true }
+arrow-ipc = { workspace = true, default-features = false, optional = true }

Review Comment:
   If the numbers justify it... I am rather confused as to how the readers 
would materially contribute to compile times, something is funky here...



##########
parquet/Cargo.toml:
##########
@@ -42,7 +42,7 @@ arrow-csv = { workspace = true, optional = true }
 arrow-data = { workspace = true, optional = true }
 arrow-schema = { workspace = true, optional = true }
 arrow-select = { workspace = true, optional = true }
-arrow-ipc = { workspace = true, optional = true }
+arrow-ipc = { workspace = true, default-features = false, optional = true }

Review Comment:
   If the numbers justify it... I am rather confused though as to how the 
readers would materially contribute to compile times, something is funky here...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to