not-my-profile commented on issue #7357:
URL:
https://github.com/apache/arrow-datafusion/issues/7357#issuecomment-1707169485
Sorry for only responding now. As I explained in #7175 my motivation was "to
feature-gate AvroExec in a followup commit, so that you cannot get bitten by
AvroExec::execute returning an NotImplemented error if the "avro" feature isn't
enabled".
I unfortunately currently don't really have time to look into this. I see
that in #7425 you're again adding the downcasting, which is hard to feature
gate and just not extensible ... I think it should really be possible to
achieve both a trait-based solution as well as the decoupling you speak of but
I'm not familiar enough with the codebase to be able to suggest the solution
and as I said don't really have time to read through the code.
If you could give me a minimal self-contained example of the APIs that have
to work together I could think of a solution, e.g:
```rust
mod physical_plan {
trait ExecutionPlan {
}
// whatever
}
mod datasource {
// whatever
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
