sgilmore10 commented on code in PR #37579:
URL: https://github.com/apache/arrow/pull/37579#discussion_r1316539978
##########
cpp/src/arrow/chunked_array.cc:
##########
@@ -111,13 +112,33 @@ bool ChunkedArray::Equals(const ChunkedArray& other)
const {
.ok();
}
-bool ChunkedArray::Equals(const std::shared_ptr<ChunkedArray>& other) const {
- if (this == other.get()) {
- return true;
+namespace {
+
+bool supportsNaN(const arrow::DataType& type) {
Review Comment:
That's definitely a better name. I'll rename the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
