js8544 commented on code in PR #37536: URL: https://github.com/apache/arrow/pull/37536#discussion_r1316998908
########## cpp/src/arrow/compute/kernels/aggregate_basic_internal.h: ########## @@ -49,20 +50,22 @@ void AddMinMaxKernel(KernelInit init, internal::detail::GetTypeId get_id, // SIMD variants for kernels void AddSumAvx2AggKernels(ScalarAggregateFunction* func); +void AddSumCheckedAvx2AggKernels(ScalarAggregateFunction* func); void AddMeanAvx2AggKernels(ScalarAggregateFunction* func); void AddMinMaxAvx2AggKernels(ScalarAggregateFunction* func); void AddSumAvx512AggKernels(ScalarAggregateFunction* func); +void AddSumCheckedAvx512AggKernels(ScalarAggregateFunction* func); void AddMeanAvx512AggKernels(ScalarAggregateFunction* func); void AddMinMaxAvx512AggKernels(ScalarAggregateFunction* func); // ---------------------------------------------------------------------- // Sum implementation -template <typename ArrowType, SimdLevel::type SimdLevel, +template <typename ArrowType, SimdLevel::type SimdLevel, bool Checked, Review Comment: I created #37585 for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
