not-my-profile commented on PR #7487: URL: https://github.com/apache/arrow-datafusion/pull/7487#issuecomment-1708049241
`get_scan_files` is [public API](https://docs.rs/datafusion/latest/datafusion/datasource/physical_plan/fn.get_scan_files.html). So just because it's not used internally doesn't mean that it's not used at all. The question is if @yahoNanJing's motivation still applies: > Currently the `TreeNodeRewriter` is as a visitor to transform a node to another. However, sometimes we don't need to do the transformation and what we want is only to collect some info from the node. To achieve this, it's better to introduce another visitor for collecting info and keep the node unchanged. As I said in https://github.com/apache/arrow-datafusion/pull/7425#discussion_r1317024608 I'm not familiar enough with datafusion to determine that. > it is unclear how best to adapt the design I think that #7485 is a decent solution if we decide to keep the function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
