pitrou commented on code in PR #34616: URL: https://github.com/apache/arrow/pull/34616#discussion_r1317161077
########## cpp/src/arrow/dataset/file_parquet.cc: ########## @@ -622,10 +640,36 @@ Result<std::shared_ptr<FileWriter>> ParquetFileFormat::MakeWriter( auto parquet_options = checked_pointer_cast<ParquetFileWriteOptions>(options); std::unique_ptr<parquet::arrow::FileWriter> parquet_writer; - ARROW_ASSIGN_OR_RAISE(parquet_writer, parquet::arrow::FileWriter::Open( - *schema, default_memory_pool(), destination, - parquet_options->writer_properties, - parquet_options->arrow_writer_properties)); + +#ifdef PARQUET_REQUIRE_ENCRYPTION Review Comment: Hmm, so what happens if `PARQUET_REQUIRE_ENCRYPTION` is false and the user sets a `parquet_encrypt_config`? We should not silently produce unencrypted files, so it should perhaps return a `Status::NotImplemented`. Also, it should probably be tested somewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
