felipecrv commented on code in PR #35345: URL: https://github.com/apache/arrow/pull/35345#discussion_r1317986330
########## cpp/src/arrow/util/list_util_test.cc: ########## @@ -0,0 +1,228 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <gtest/gtest.h> + +#include "arrow/array/builder_nested.h" +#include "arrow/util/list_util.h" + +#include "arrow/testing/builder.h" +#include "arrow/testing/gtest_util.h" + +namespace arrow { + +using internal::checked_cast; +using internal::checked_pointer_cast; + +using ListAndListViewTypes = + ::testing::Types<ListType, LargeListType, ListViewType, LargeListViewType>; + +template <typename T> +class TestListUtils : public ::testing::Test { + public: + using TypeClass = T; + using offset_type = typename TypeClass::offset_type; + using BuilderType = typename TypeTraits<TypeClass>::BuilderType; + + void SetUp() override { + value_type_ = int16(); + type_ = std::make_shared<T>(value_type_); + + std::unique_ptr<ArrayBuilder> tmp; + ASSERT_OK(MakeBuilder(pool_, type_, &tmp)); + builder_.reset(checked_cast<BuilderType*>(tmp.release())); + } + + void TestRangeOfValuesUsed() { + std::shared_ptr<ArrayData> result; + + // Empty list-like array + ASSERT_OK(builder_->FinishInternal(&result)); Review Comment: `ArrayFromJSON` can't create list-views with overlapping ranges and other weird variations that are important for `RangeOfValuesUsed`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
